provide dist/underscore.string.min.js in the npm package (again)
#402
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is okay for me. |
|
Yes. I also think the both |
|
@Mithgol could you remove |
|
Yep. |
|
Could you drop the first unused commit? Thanks |
|
Ok. |
stoeffel
added a commit
that referenced
this pull request
Feb 6, 2015
provide `dist/underscore.string.min.js` in the npm package (again)
|
Thanks 💯 |
|
Could you |
|
I will tomorrow. 😄 |
|
@Mithgol 3.0.3 is released. |
Mithgol
added a commit
to Mithgol/phido
that referenced
this pull request
Feb 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser window's context and Node.js context are different in nw.js and it takes some time to switch between them.
Therefore, when
underscore.stringis used inside an nwjs-based application, it sometimes makes sense to do both of the following:underscore.stringas a dependency inpackage.json(example) and let it be installed withnpm installunderscore.stringin a browser's window context with<script>(example) instead of (or in addition to) Node.js context withrequire().However, the npm package of
underscore.stringdoes not currently contain thedist/underscore.string.min.jsfile that could be installed and referenced by thescriptelement.That's why this pull request partially reverts c3088d4 (and #193): the minified file
dist/underscore.string.min.jsis re-added to the npm package. (The larger filedist/underscore.string.jscontinues to be removed from the package.)